david
9f673bfca3
Remove soft delete from HabitEntry: - Eliminate DeletedAt field from entity and database - Change UnmarkHabit from soft delete to hard delete - Simplify all queries removing deleted_at checks - Update migration to remove deleted_at column Add date filtering and smart pagination to GetHabitEntries: - Support optional from/to date parameters - Implement intelligent pagination rules: * No date range: pagination required * Date range > 1 year: pagination required * Date range ≤ 1 year: pagination optional - Pagination defaults (page=1, limit=50) only when required - Return metadata with total count, page, and limit Technical improvements: - Cleaner codebase without soft delete complexity - Better performance (no filtering in queries) - More intuitive API with flexible pagination - Comprehensive test coverage for validation rules
142 lines
3.5 KiB
Go
142 lines
3.5 KiB
Go
package commands
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"apocapoc-api/internal/domain/entities"
|
|
"apocapoc-api/internal/domain/value_objects"
|
|
"apocapoc-api/internal/shared/errors"
|
|
)
|
|
|
|
type mockEntryRepoForUnmark struct {
|
|
mockEntryRepo
|
|
entries []*entities.HabitEntry
|
|
deletedEntryID string
|
|
errorOnDelete error
|
|
}
|
|
|
|
func (m *mockEntryRepoForUnmark) FindByHabitIDAndDateRange(ctx context.Context, habitID string, from, to time.Time) ([]*entities.HabitEntry, error) {
|
|
return m.entries, nil
|
|
}
|
|
|
|
func (m *mockEntryRepoForUnmark) Delete(ctx context.Context, id string) error {
|
|
if m.errorOnDelete != nil {
|
|
return m.errorOnDelete
|
|
}
|
|
m.deletedEntryID = id
|
|
return nil
|
|
}
|
|
|
|
func TestUnmarkHabitHandler_UnmarksSuccessfully(t *testing.T) {
|
|
habit := entities.NewHabit("user-123", "Exercise", value_objects.HabitTypeBoolean, value_objects.FrequencyDaily, false)
|
|
habit.ID = "habit-1"
|
|
|
|
scheduledDate := time.Date(2025, 1, 15, 0, 0, 0, 0, time.UTC)
|
|
entry := entities.NewHabitEntry("habit-1", scheduledDate, nil)
|
|
entry.ID = "entry-1"
|
|
|
|
habitRepo := &mockHabitRepoForUpdate{
|
|
habitToReturn: habit,
|
|
}
|
|
|
|
entryRepo := &mockEntryRepoForUnmark{
|
|
entries: []*entities.HabitEntry{entry},
|
|
}
|
|
|
|
handler := NewUnmarkHabitHandler(habitRepo, entryRepo)
|
|
|
|
cmd := UnmarkHabitCommand{
|
|
HabitID: "habit-1",
|
|
UserID: "user-123",
|
|
ScheduledDate: scheduledDate,
|
|
}
|
|
|
|
err := handler.Handle(context.Background(), cmd)
|
|
|
|
if err != nil {
|
|
t.Fatalf("Expected no error, got %v", err)
|
|
}
|
|
|
|
if entryRepo.deletedEntryID != "entry-1" {
|
|
t.Errorf("Expected entry entry-1 to be deleted, got %s", entryRepo.deletedEntryID)
|
|
}
|
|
}
|
|
|
|
func TestUnmarkHabitHandler_ReturnsErrorWhenHabitNotFound(t *testing.T) {
|
|
habitRepo := &mockHabitRepoForUpdate{
|
|
errorOnFind: errors.ErrNotFound,
|
|
}
|
|
|
|
entryRepo := &mockEntryRepoForUnmark{}
|
|
|
|
handler := NewUnmarkHabitHandler(habitRepo, entryRepo)
|
|
|
|
cmd := UnmarkHabitCommand{
|
|
HabitID: "non-existent",
|
|
UserID: "user-123",
|
|
ScheduledDate: time.Now(),
|
|
}
|
|
|
|
err := handler.Handle(context.Background(), cmd)
|
|
|
|
if err != errors.ErrNotFound {
|
|
t.Errorf("Expected ErrNotFound, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestUnmarkHabitHandler_ReturnsErrorWhenUserDoesNotOwnHabit(t *testing.T) {
|
|
habit := entities.NewHabit("user-123", "Exercise", value_objects.HabitTypeBoolean, value_objects.FrequencyDaily, false)
|
|
habit.ID = "habit-1"
|
|
|
|
habitRepo := &mockHabitRepoForUpdate{
|
|
habitToReturn: habit,
|
|
}
|
|
|
|
entryRepo := &mockEntryRepoForUnmark{}
|
|
|
|
handler := NewUnmarkHabitHandler(habitRepo, entryRepo)
|
|
|
|
cmd := UnmarkHabitCommand{
|
|
HabitID: "habit-1",
|
|
UserID: "user-456", // Different user
|
|
ScheduledDate: time.Now(),
|
|
}
|
|
|
|
err := handler.Handle(context.Background(), cmd)
|
|
|
|
if err != errors.ErrUnauthorized {
|
|
t.Errorf("Expected ErrUnauthorized, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestUnmarkHabitHandler_ReturnsErrorWhenEntryNotFound(t *testing.T) {
|
|
habit := entities.NewHabit("user-123", "Exercise", value_objects.HabitTypeBoolean, value_objects.FrequencyDaily, false)
|
|
habit.ID = "habit-1"
|
|
|
|
habitRepo := &mockHabitRepoForUpdate{
|
|
habitToReturn: habit,
|
|
}
|
|
|
|
// No entries
|
|
entryRepo := &mockEntryRepoForUnmark{
|
|
entries: []*entities.HabitEntry{},
|
|
}
|
|
|
|
handler := NewUnmarkHabitHandler(habitRepo, entryRepo)
|
|
|
|
cmd := UnmarkHabitCommand{
|
|
HabitID: "habit-1",
|
|
UserID: "user-123",
|
|
ScheduledDate: time.Date(2025, 1, 15, 0, 0, 0, 0, time.UTC),
|
|
}
|
|
|
|
err := handler.Handle(context.Background(), cmd)
|
|
|
|
if err != errors.ErrNotFound {
|
|
t.Errorf("Expected ErrNotFound for missing entry, got %v", err)
|
|
}
|
|
}
|
|
|