feat: allow editing frequency and target_value on habits

- Add frequency to UpdateHabitRequest (was immutable, now editable)
- Validate frequency + specific_days/dates coherence on update
- Keep type and is_negative immutable (they change entry semantics)
- Remove completion_rate references from swagger and README

README.md

@@ -20,7 +20,7 @@ REST API for habit tracking built with Go. Self-hosted alternative for developer
 
 - Multiple habit types: Boolean, Counter, Value
 - Flexible scheduling: Daily, Weekly, Monthly
-- Statistics: Streaks, completion rates, progress tracking
+- Statistics: Streaks and completions tracking
 - JWT authentication, rate limiting, optional email verification
 - Registration modes: Open or closed
 - SQLite database (single file)

docs/docs.go

@@ -1172,7 +1172,7 @@ const docTemplate = `{
                         "BearerAuth": []
                     }
                 ],
-                "description": "Get statistics for a specific habit including streaks and completion rates",
+                "description": "Get statistics for a specific habit including streaks and completions",
                 "produces": [
                     "application/json"
                 ],
@@ -1800,6 +1800,12 @@ const docTemplate = `{
                 "description": {
                     "type": "string"
                 },
+                "frequency": {
+                    "$ref": "#/definitions/value_objects.Frequency"
+                },
+                "is_negative": {
+                    "type": "boolean"
+                },
                 "name": {
                     "type": "string"
                 },

docs/swagger.json

@@ -1164,7 +1164,7 @@
                         "BearerAuth": []
                     }
                 ],
-                "description": "Get statistics for a specific habit including streaks and completion rates",
+                "description": "Get statistics for a specific habit including streaks and completions",
                 "produces": [
                     "application/json"
                 ],
@@ -1792,6 +1792,12 @@
                 "description": {
                     "type": "string"
                 },
+                "frequency": {
+                    "$ref": "#/definitions/value_objects.Frequency"
+                },
+                "is_negative": {
+                    "type": "boolean"
+                },
                 "name": {
                     "type": "string"
                 },

docs/swagger.yaml

@@ -268,6 +268,10 @@ definitions:
         type: boolean
       description:
         type: string
+      frequency:
+        $ref: '#/definitions/value_objects.Frequency'
+      is_negative:
+        type: boolean
       name:
         type: string
       specific_dates:
@@ -1189,8 +1193,7 @@ paths:
       - system
   /stats/habits/{id}:
     get:
-      description: Get statistics for a specific habit including streaks and completion
+      description: Get statistics for a specific habit including streaks and completions
-        rates
       parameters:
       - description: Habit ID
         in: path

internal/application/commands/update_habit.go

@@ -5,6 +5,7 @@ import (
 	"strings"
 
 	"apocapoc-api/internal/domain/repositories"
+	"apocapoc-api/internal/domain/value_objects"
 	"apocapoc-api/internal/shared/errors"
 )
 
@@ -13,10 +14,11 @@ type UpdateHabitCommand struct {
 	UserID        string
 	Name          string
 	Description   string
-	CarryOver     bool
+	Frequency     value_objects.Frequency
-	TargetValue   *float64
 	SpecificDays  []int
 	SpecificDates []int
+	CarryOver     bool
+	TargetValue   *float64
 }
 
 type UpdateHabitHandler struct {
@@ -34,6 +36,18 @@ func (h *UpdateHabitHandler) Handle(ctx context.Context, cmd UpdateHabitCommand)
 		return errors.ErrInvalidInput
 	}
 
+	if !cmd.Frequency.IsValid() {
+		return errors.ErrInvalidInput
+	}
+
+	if cmd.Frequency == value_objects.FrequencyWeekly && len(cmd.SpecificDays) == 0 {
+		return errors.ErrInvalidInput
+	}
+
+	if cmd.Frequency == value_objects.FrequencyMonthly && len(cmd.SpecificDates) == 0 {
+		return errors.ErrInvalidInput
+	}
+
 	habit, err := h.habitRepo.FindByID(ctx, cmd.HabitID)
 	if err != nil {
 		return err
@@ -49,10 +63,11 @@ func (h *UpdateHabitHandler) Handle(ctx context.Context, cmd UpdateHabitCommand)
 
 	habit.Name = cmd.Name
 	habit.Description = cmd.Description
-	habit.CarryOver = cmd.CarryOver
+	habit.Frequency = cmd.Frequency
-	habit.TargetValue = cmd.TargetValue
 	habit.SpecificDays = cmd.SpecificDays
 	habit.SpecificDates = cmd.SpecificDates
+	habit.CarryOver = cmd.CarryOver
+	habit.TargetValue = cmd.TargetValue
 
 	return h.habitRepo.Update(ctx, habit)
 }

internal/application/commands/update_habit_test.go

@@ -48,9 +48,10 @@ func TestUpdateHabitHandler_UpdatesSuccessfully(t *testing.T) {
 		UserID:       "user-123",
 		Name:         "Morning Exercise",
 		Description:  "Updated description",
+		Frequency:    value_objects.FrequencyWeekly,
+		SpecificDays: []int{1, 3, 5},
 		CarryOver:    true,
 		TargetValue:  &newTargetValue,
-		SpecificDays: []int{1, 3, 5},
 	}
 
 	err := handler.Handle(context.Background(), cmd)
@@ -67,6 +68,14 @@ func TestUpdateHabitHandler_UpdatesSuccessfully(t *testing.T) {
 		t.Errorf("Expected description to be updated, got %s", habitRepo.updatedHabit.Description)
 	}
 
+	if habitRepo.updatedHabit.Frequency != value_objects.FrequencyWeekly {
+		t.Errorf("Expected frequency WEEKLY, got %s", habitRepo.updatedHabit.Frequency)
+	}
+
+	if len(habitRepo.updatedHabit.SpecificDays) != 3 {
+		t.Errorf("Expected 3 specific days, got %d", len(habitRepo.updatedHabit.SpecificDays))
+	}
+
 	if !habitRepo.updatedHabit.CarryOver {
 		t.Error("Expected CarryOver to be true")
 	}
@@ -74,10 +83,6 @@ func TestUpdateHabitHandler_UpdatesSuccessfully(t *testing.T) {
 	if habitRepo.updatedHabit.TargetValue == nil || *habitRepo.updatedHabit.TargetValue != 5.0 {
 		t.Errorf("Expected target value 5.0, got %v", habitRepo.updatedHabit.TargetValue)
 	}
-
-	if len(habitRepo.updatedHabit.SpecificDays) != 3 {
-		t.Errorf("Expected 3 specific days, got %d", len(habitRepo.updatedHabit.SpecificDays))
-	}
 }
 
 func TestUpdateHabitHandler_ReturnsErrorWhenHabitNotFound(t *testing.T) {
@@ -91,6 +96,7 @@ func TestUpdateHabitHandler_ReturnsErrorWhenHabitNotFound(t *testing.T) {
 		HabitID:   "non-existent",
 		UserID:    "user-123",
 		Name:      "Exercise",
+		Frequency: value_objects.FrequencyDaily,
 	}
 
 	err := handler.Handle(context.Background(), cmd)
@@ -114,6 +120,7 @@ func TestUpdateHabitHandler_ReturnsErrorWhenUserDoesNotOwnHabit(t *testing.T) {
 		HabitID:   "habit-1",
 		UserID:    "user-456", // Different user
 		Name:      "Exercise",
+		Frequency: value_objects.FrequencyDaily,
 	}
 
 	err := handler.Handle(context.Background(), cmd)
@@ -138,6 +145,7 @@ func TestUpdateHabitHandler_CannotUpdateArchivedHabit(t *testing.T) {
 		HabitID:   "habit-1",
 		UserID:    "user-123",
 		Name:      "Updated Exercise",
+		Frequency: value_objects.FrequencyDaily,
 	}
 
 	err := handler.Handle(context.Background(), cmd)
@@ -161,6 +169,7 @@ func TestUpdateHabitHandler_ValidatesInput(t *testing.T) {
 		HabitID:   "habit-1",
 		UserID:    "user-123",
 		Name:      "", // Empty name
+		Frequency: value_objects.FrequencyDaily,
 	}
 
 	err := handler.Handle(context.Background(), cmd)
@@ -169,3 +178,57 @@ func TestUpdateHabitHandler_ValidatesInput(t *testing.T) {
 		t.Errorf("Expected ErrInvalidInput for empty name, got %v", err)
 	}
 }
+
+func TestUpdateHabitHandler_InvalidFrequency(t *testing.T) {
+	habitRepo := &mockHabitRepoForUpdate{}
+	handler := NewUpdateHabitHandler(habitRepo)
+
+	cmd := UpdateHabitCommand{
+		HabitID:   "habit-1",
+		UserID:    "user-123",
+		Name:      "Exercise",
+		Frequency: "INVALID",
+	}
+
+	err := handler.Handle(context.Background(), cmd)
+
+	if err != errors.ErrInvalidInput {
+		t.Errorf("Expected ErrInvalidInput for invalid frequency, got %v", err)
+	}
+}
+
+func TestUpdateHabitHandler_WeeklyRequiresSpecificDays(t *testing.T) {
+	habitRepo := &mockHabitRepoForUpdate{}
+	handler := NewUpdateHabitHandler(habitRepo)
+
+	cmd := UpdateHabitCommand{
+		HabitID:   "habit-1",
+		UserID:    "user-123",
+		Name:      "Exercise",
+		Frequency: value_objects.FrequencyWeekly,
+	}
+
+	err := handler.Handle(context.Background(), cmd)
+
+	if err != errors.ErrInvalidInput {
+		t.Errorf("Expected ErrInvalidInput for weekly without specific days, got %v", err)
+	}
+}
+
+func TestUpdateHabitHandler_MonthlyRequiresSpecificDates(t *testing.T) {
+	habitRepo := &mockHabitRepoForUpdate{}
+	handler := NewUpdateHabitHandler(habitRepo)
+
+	cmd := UpdateHabitCommand{
+		HabitID:   "habit-1",
+		UserID:    "user-123",
+		Name:      "Exercise",
+		Frequency: value_objects.FrequencyMonthly,
+	}
+
+	err := handler.Handle(context.Background(), cmd)
+
+	if err != errors.ErrInvalidInput {
+		t.Errorf("Expected ErrInvalidInput for monthly without specific dates, got %v", err)
+	}
+}

internal/infrastructure/http/dto.go

@@ -22,6 +22,7 @@ type CreateHabitRequest struct {
 type UpdateHabitRequest struct {
 	Name          string                  `json:"name"`
 	Description   string                  `json:"description"`
+	Frequency     value_objects.Frequency `json:"frequency"`
 	SpecificDays  []int                   `json:"specific_days,omitempty"`
 	SpecificDates []int                   `json:"specific_dates,omitempty"`
 	CarryOver     bool                    `json:"carry_over"`

internal/infrastructure/http/habit_handlers.go

@@ -313,10 +313,11 @@ func (h *HabitHandlers) UpdateHabit(w http.ResponseWriter, r *http.Request) {
 		UserID:        userID,
 		Name:          req.Name,
 		Description:   req.Description,
-		CarryOver:     req.CarryOver,
+		Frequency:     req.Frequency,
-		TargetValue:   req.TargetValue,
 		SpecificDays:  req.SpecificDays,
 		SpecificDates: req.SpecificDates,
+		CarryOver:     req.CarryOver,
+		TargetValue:   req.TargetValue,
 	}
 
 	if err := h.updateHandler.Handle(r.Context(), cmd); err != nil {

internal/infrastructure/http/habit_integration_test.go

@@ -89,6 +89,7 @@ func TestHabitCRUDFlow(t *testing.T) {
 		reqBody := UpdateHabitRequest{
 			Name:        "Morning Exercise",
 			Description: "Updated description",
+			Frequency:   "DAILY",
 		}
 
 		rr := makeRequest(t, *ts.Router, "PUT", "/api/v1/habits/"+habitID, reqBody, token)

internal/infrastructure/http/stats_handlers.go

@@ -27,7 +27,7 @@ func NewStatsHandlers(
 
 // GetHabitStats godoc
 // @Summary Get habit statistics
-// @Description Get statistics for a specific habit including streaks and completion rates
+// @Description Get statistics for a specific habit including streaks and completions
 // @Tags stats
 // @Produce json
 // @Security BearerAuth

internal/infrastructure/http/stats_integration_test.go

@@ -121,6 +121,7 @@ func TestHabitUpdateAffectsStats(t *testing.T) {
 	t.Run("Stats remain after updating habit name", func(t *testing.T) {
 		updateReq := UpdateHabitRequest{
 			Name:      "Morning Running",
+			Frequency: "DAILY",
 		}
 		rr := makeRequest(t, *ts.Router, "PUT", "/api/v1/habits/"+habitID, updateReq, token)
 		if rr.Code != http.StatusOK {