Refactor password hashing to follow DIP and improve CI/CD
CI/CD Pipeline / Test (push) Has been cancelled
CI/CD Pipeline / Lint (push) Has been cancelled
CI/CD Pipeline / Build and Push Docker Image (push) Has been cancelled

- Create PasswordHasher interface in domain layer
- Implement BcryptHasher in infrastructure layer
- Update RegisterUserHandler and LoginUserHandler to use interface
- Remove bcrypt dependency from application layer
- Update main.go and integration tests with dependency injection
- Enhance CI/CD workflow with test and lint jobs
- Add code coverage check (minimum 50%)
- Add go vet and gofmt validation
- Configure build job to depend on test and lint passing
- Update GitHub Actions to latest versions (v4→v5)

This achieves 100% SOLID compliance (DIP) and ensures Clean Architecture
by removing external library dependencies from application/domain layers.
This commit is contained in:
2025-11-26 21:39:52 +01:00
parent daa7154b12
commit 4c8f3022f0
7 changed files with 114 additions and 23 deletions
@@ -0,0 +1,25 @@
package crypto
import (
"apocapoc-api/internal/domain/services"
"golang.org/x/crypto/bcrypt"
)
type BcryptHasher struct{}
func NewBcryptHasher() services.PasswordHasher {
return &BcryptHasher{}
}
func (b *BcryptHasher) Hash(password string) (string, error) {
hashedBytes, err := bcrypt.GenerateFromPassword([]byte(password), bcrypt.DefaultCost)
if err != nil {
return "", err
}
return string(hashedBytes), nil
}
func (b *BcryptHasher) Compare(hashedPassword, password string) error {
return bcrypt.CompareHashAndPassword([]byte(hashedPassword), []byte(password))
}
@@ -11,6 +11,7 @@ import (
"apocapoc-api/internal/application/commands"
"apocapoc-api/internal/application/queries"
"apocapoc-api/internal/infrastructure/auth"
"apocapoc-api/internal/infrastructure/crypto"
"apocapoc-api/internal/infrastructure/persistence/sqlite"
_ "github.com/mattn/go-sqlite3"
@@ -32,13 +33,14 @@ func setupTestServer(t *testing.T) *TestServer {
}
jwtService := auth.NewJWTService("test-secret", 24)
passwordHasher := crypto.NewBcryptHasher()
userRepo := sqlite.NewUserRepository(db)
habitRepo := sqlite.NewHabitRepository(db)
entryRepo := sqlite.NewHabitEntryRepository(db)
registerHandler := commands.NewRegisterUserHandler(userRepo)
loginHandler := queries.NewLoginUserHandler(userRepo)
registerHandler := commands.NewRegisterUserHandler(userRepo, passwordHasher)
loginHandler := queries.NewLoginUserHandler(userRepo, passwordHasher)
createHandler := commands.NewCreateHabitHandler(habitRepo)
getTodaysHandler := queries.NewGetTodaysHabitsHandler(habitRepo, entryRepo)
getUserHabitsHandler := queries.NewGetUserHabitsHandler(habitRepo)